Lucio Franco comments

Results 524 comments of


                                            Lucio Franco

Fine-grained selection of where to add type or field attributes using filters

@marjakm you will need to rebase against master to get CI working again

Fine-grained selection of where to add type or field attributes using filters

I think something like this could eventually be merged but I am not sure atm if this is the right approach.

Rust-specific `.proto` field option (optionally: comment) to be turned into an attribute

Could you explain more about the design you're proposing? I am cautious to add more dependencies even if they are behind a feature gate.

Rust-specific `.proto` field option (optionally: comment) to be turned into an attribute

So I think this sounds interesting but the main concerns I have is I'd not really like to add this as a dependency even if its behind a feature flag....

Rust-specific `.proto` field option (optionally: comment) to be turned into an attribute

My concern by adding something like this is that another user might want a different decorator library and supporting all of them is out of scope of this project. Even...

Double-copy merging String and Vec<u8> from inputs that are not Bytes

Thanks for digging into this. I wonder if we should just make `Bytes` the default?

[Featture-Request] Ability to swap HashMap

This seems like an interesting idea similar to how prost supports bytes. That said, I am not sure if it is a good idea to add this if the change...

Bug?: How to register parent packages to extern_paths

What does your `build.rs` for `parent_package` look like?

Remove cmake

I am curious if this supports https://github.com/tokio-rs/console/blob/main/console-api/build.rs#L17 this flag?

Remove cmake

I must be allergic to c++ code thanks for getting that lmaooo