Lucio Franco comments

Results 524 comments of


                                            Lucio Franco

Use `cleanup-markdown` `prost_build` feature

Good idea, we can add a new feature to `tonic-build` that just forwards that specific feature. I would accept a PR for this.

Use `cleanup-markdown` `prost_build` feature

I believe the best spot to read about it is here https://doc.rust-lang.org/cargo/reference/features.html

Simple version check in tonic_build

If you find a good solution for that then sure! But we need to be careful because its still allowed to use different versions of tonic in the same project.

Unwanted logs after applying tower middleware

How are you filtering your logs? These are just the h2 debug logs used by the http2 implementation tonic is using.

Add From<T> for Response<T>

I am trying to remember why we didn't include this. I know for requests we have `IntoRequest`. But I can't come up with why we shouldn't include this. Would love...

Add From<T> for Response<T>

This is going to have to wait for the next breaking change release.

How to skip a field in prost?

I do not believe this is currently a feature of prost, so will need to be RFC and added.

Is there a way to provide repeated fields as iterator rather than Vec?

Unfortunately, a Vec is required. Supporting generic iterators is quite hard to support I believe.

Type erased sync Service

I wonder if you could use this https://docs.rs/sync_wrapper/0.1.1/sync_wrapper/struct.SyncWrapper.html

Type erased sync Service

To convert from a `&self` anyways for a service requires a clone so I don't think you can skip out on that.