Add Roborock Consumable sensors
Breaking change
Proposed change
There are a lot of sensors that Roborock Vacuums can expose but they vary from device to device. Consumable information should be present on every Roborock vacuum - so I figured these were a good subset of sensors to introduce the platform with.
Type of change
- [ ] Dependency upgrade
- [ ] Bugfix (non-breaking change which fixes an issue)
- [ ] New integration (thank you!)
- [x] New feature (which adds functionality to an existing integration)
- [ ] Deprecation (breaking change to happen in the future)
- [ ] Breaking change (fix/feature causing existing functionality to break)
- [ ] Code quality improvements to existing code or addition of tests
Additional information
- This PR fixes or closes issue: fixes #
- This PR is related to issue:
- Link to documentation pull request: https://github.com/home-assistant/home-assistant.io/pull/27137
Checklist
- [x] The code change is tested and works locally.
- [x] Local tests pass. Your PR cannot be merged unless tests pass
- [x] There is no commented out code in this PR.
- [x] I have followed the development checklist
- [x] I have followed the perfect PR recommendations
- [x] The code has been formatted using Black (
black --fast homeassistant tests) - [x] Tests have been added to verify that the new code works.
If user exposed functionality or configuration variables are added/changed:
- [x] Documentation added/updated for www.home-assistant.io
If the code communicates with devices, web services, or third-party tools:
- [x] The manifest file has all fields filled out correctly.
Updated and included derived files by running:python3 -m script.hassfest. - [x] New or updated dependencies have been added to
requirements_all.txt.
Updated by runningpython3 -m script.gen_requirements_all. - [ ] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
- [ ] Untested files have been added to
.coveragerc.
To help with the load of incoming pull requests:
- [ ] I have reviewed two other open pull requests in this repository.
Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!
Code owner commands
Code owners of roborock can trigger bot actions by commenting:
@home-assistant closeCloses the pull request.@home-assistant rename Awesome new titleRenames the pull request.@home-assistant reopenReopen the pull request.@home-assistant unassign roborockRemoves the current integration label and assignees on the pull request, add the integration domain after the command.
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks :+1:
Converted back to draft, see comment above.
As a note - this conflicts with #92547 But the changes needed will be minor, I will update whichever one gets merged in second to respect the other
Are there any remaining holdouts or concerns that anyone would like me to resolve?
@emontnemery mypy fails on dev after this merge:
https://github.com/home-assistant/core/actions/runs/5072203871/jobs/9109610267
I have been out of town since #92547 was merged and until this morning. #92547 bumped the version and made some changes to how things work for Roborock and made this conflicting.
I can fix it, but I am unfortunately stuck in meetings for the new few hours.
I had a chance to do it in the background of a meeting.
Fixed here: #93488