Larry Ruane
Larry Ruane
> Well that’s not cool You're right, it's not cool! I submitted a fix (#57) but no one seems to be around to merge it. (I forgot all about this...
This PR includes a unit test, and I also tested it manually: We usually don't have any pending network upgrades, so to test manually, I replaced "pending" with "active" in...
Depends on zcash/lightwallet-protocol#8
Force pushed to rebase onto the latest lightwallet-protocol; this is ready for review.
This patch would have helped me; I'm new to `cmake`; after building it for the first time, I tried to run the functional tests (the way I was used to),...
@fanquake - thanks, I'll fix all these this weekend.
Force pushed 6ab688c74b61c4403f831f1df54a350548ce8664 to restore the accidentally-dropped change that Jon pointed out.
Force pushed Jon's suggestion, thanks - https://github.com/bitcoin/bitcoin/pull/30859#discussion_r1795456841
Yes, this would be very valuable. I'd like to attempt to get this going; @dergoegge, would that be okay? I made a related [comment](https://github.com/bitcoin/bitcoin/pull/26957#issuecomment-1474874821) last week before I was aware...
I tried manually testing both `GetMempoolTx` and `GetMempoolStream` (using `zcashd` and `grpcurl` on mainnet, just waiting until transactions appear in the mempool), using the latest master branch commit (6c400288240615ad4c59e748fd876466553c2e3f) and...