Larry Ruane

Results 228 comments of Larry Ruane

Should we do this? This would give the user an alternative to command-line arguments, even without regard to load balancing, orchestration, etc. More config options for those things and others...

Sounds good to me, @pacu, @gmale, @mdr0id, do you have an opinion on this?

Thanks for reporting this, Gareth! With the latest master (commit 1e40cea877395988847c7c063cd7bf4c4ad888a5), it fails this way for me: ``` WARNING[2019-09-05T15:51:09-06:00] error with getblock app=lightwd error="error requesting block: Post http://127.0.0.1: dial tcp...

Update, sorry, ignore my previous comment (and my PR); I wasn't on `master`. Is this still a problem for you? If so, which branch are you on (commit hash would...

ACK a7432dd6ed3e13a272d62ecde535e6d562cc932c

The results of the old and new versions of this function should differ only slightly; it would be bad if the new one gave very different results, because node operators...

Changing to draft because CI on a couple of the platforms failed the new test, so the physical memory calculation will need to be different on those platforms, I try...

Force-pushed to 04f3fbe308728d2fb18fad418603cab97f0b9f59 - rebase only. (CI is still expected to fail, I'm working on that now.)

@martinus Can you think of why the macOS and Win64 are failing (I have only Ubuntu, which passes)? As an experiment, I changed the memory usage ratio needed to pass...

@sipa - I don't think the test failures could be due to differences in memory allocation overhead across platforms. The actual memory allocation overhead isn't being tested at all. To...