Larry Ruane

Results 228 comments of Larry Ruane

@martinus - thanks, that makes perfect sense! I hadn't thought of the possibility of the nodes having two pointers instead of one (double instead of single linked list). Seems like...

**NOTE**, this PR isn't ready to merge; at the very least it has some debug prints that need to be removed. CI was failing on some platforms (Windows and macOS),...

Your patch is much better, @theStack, thanks! It's simpler and doesn't need that weird `sleep`. Force-pushed your patch. If it passes CI, I think this is the way to go....

CI passed, thanks @theStack. I just force-pushed swapping of the two commits, the test commit has to be first for each commit to pass CI.

This PR includes some whitespace changes to common/common_test.go because my IDE (vscode) automatically formats files, and an earlier commit to this file used a different formatting convention. I recommend viewing...

Part of this patch (the small change to `cmd/root.go`) requires https://github.com/zcash/zcash/pull/6972 to be effective (not be a no-op), but this PR can be merged without (or before) 6972 is merged;...

Rebased to fix merge conflicts, I believe this is ready to merge and it is safe, hoping for more review (thanks for your review, @y4ssi).

Here's an example of the difference in the error returns. Start a `lightwalletd` instance on mainnet, then try to fetch a non-existent transaction (but the length of the txid is...

force-pushed to make two small formatting improvements

The latest (force) push was to rebase, and also remove the changes that were to go along with https://github.com/zcash/zcash/pull/6972 but we decided not to do these changes, at least for...