Lloyd Fournier
Lloyd Fournier
> ### Description > > WIP towards removing `rand` #871 > > The `rand` dependency was imported explicitly, but `rand` is also implicitly used through the `rand-std` feature flag on...
> > If we want randomness during signing (it's a good default), then we should make the caller pass in an Rng and call: [sign_schnorr_wth_aux_rand](https://docs.rs/bitcoin/latest/bitcoin/key/struct.Secp256k1.html#method.sign_schnorr_with_aux_rand) rather than the one that...
> _Updated_: The PR now uses `Option` as a `SignOptions` for additional entropy on Schnorr signatures. While I think this is the lowest hanging fruit so-to-speak, I think it would...
The plan above sounds good. As an aside I'm going to work on replacing the coin selection code with `bdk_coin_select`. We will probably fall back to "largest first" if BnB...
FWIW I would love to remove "signers" from the wallet and just have a bunch of ways to sign PSBT inputs with fine grained control about what is signed. It...
> With the new `ChainOracle` design, it no longer makes sense to have this as part of the keychain tracker. It might make sense to have this inside the bdk...
@DanGould reconsidering the problem here. Is there something wrong with just using: [`add_unspendable`](https://docs.rs/bdk/1.0.0-alpha.8/bdk/wallet/tx_builder/struct.TxBuilder.html#method.add_unspendable) when you don't want to spend a txout because you know at the application level which transactions...
@DanGould thanks for the context. 1. Inserting transactions before they are broadcast: I actually thought this would be fine but it looks like we've got bug that means that if...
`None` would be in no ones mempool (not even yours). You can have a transaction that is valid but has never left application memory. But I realized after writing this...
Indeed an alternative proposal is to treat 0 as a magic value. But this means that two states have the same semantics (when the `last_seen` is `0` and when it...