Lloyd Fournier

Results 280 comments of Lloyd Fournier

> Since the purpose of the `bdk_wallet` crate is to provide useful/opinionated ways to perform standard wallet tasks, it feels to me like a simple-to-use "get me all important—nicely bundled...

I think I mentioned elsewhere that we shouldn't try to detect this other than a simple eq comparison and just consider a user error that leads to undefined behavior. I...

> What do you mean by "it should just create a tx with the appropriate fee that spends one or more of the existing transaction's outputs"? I assume you mean...

Ok but the FFI bindings can depend on `rand` and pass in `ThreadRng` if they want to?

> > We don't have to test on MSRV we just have to check that it builds on MSRV. dev-dependencies shouldn't have to be pinned. > > I disagree: MSRV...

> One might expect that the `Wallet.transactions()` method replaced the `Wallet.list_transactions()` and will return similar transactions (the transactions related to the descriptors the wallet tracks). This is not the case,...

Although sending has less moving parts I'm less sure what's the right API inside transaction building system (mostly because we haven't re-designed transaction building yet). With receiving I know precisely...

While implementing it we might be able to contribute to the BIP if we find places it could be improved.

They are all shares. Just prefix with `keychain_shares`. `signing_shares`.

note `secp256k1` is not upstream from this crate. `secp256k1` offers a high level API which is pretty type safe for most things that are designed to be done with it....