Ivan Kochurkin

Results 260 comments of Ivan Kochurkin

Does it make sense to use IDEA notifications, maybe it looks more natively and expected, see https://www.jetbrains.com/help/idea/notifications.html

@parrt any chance it will be reviewed and merged this time?

No, I suggest adding a test data in the way @Beakerboy suggested.

Why is it not possible to use existing descriptors with JUnit? We can just write another `KotlinWasmRunner` like current [`KotlinRunner`](https://github.com/antlr/antlr5/blob/dev/runtime-testsuite/test/org/antlr/v5/test/runtime/kotlin/KotlinRunner.java).

> Also, I'm not sure how it would work with K/WASM (or even K/JS). Will it perform any DCE? Will the symbol names be retained or mangled? Will we be...

> This is a big problem in ANTLR as crashing a thread usually crashes the entire app (nice DDOS attack)! Some runtimes have methods that could check if there is...

> The root cause should be removed instead of all these workarounds. In my [next generation ANTLR project](https://github.com/mike-lischke/ANTLRng) I plan to convert the recursive prediction code to become iterative and...

> So what he meant was that the JVM simply crashes? True, unfortunately JVM can't handle huge arrays unlike other runtimes out of box. But it's probably possible to use...

I don't remember why it was implemented in that way, maybe it was just more easier. I've found a related PR: https://github.com/antlr/antlr4/pull/3591