Ivan Kochurkin
Ivan Kochurkin
I can push `!fixup` commits to make further review easier (review only changes instead of entire PR). Before the final merging, I'll squash `!fixup` commit with ordinary ones.
It looks like the similar bug was already reported: https://github.com/antlr/antlr4/issues/2179 But it's about weird error instead of different parsing result.
> s : 'a' EOF 'c' | 'b' ; I think such code should be disallowed. `EOF` might be placed only at the end position of the rule. [`EOF_CLOSURE`](https://github.com/antlr/antlr4/blob/dev/tool/src/org/antlr/v4/tool/ErrorType.java#L1120) error...
> are in one alt and missing in another; ~~Why do you think it should be disallowed? It's quite real code.~~ Yes, it looks like it also doesn't make sense....
@kaby76 related issue for `skip` tokens: https://github.com/antlr/antlr4/issues/2886 (but with using of `FRAGMENT` instead of `skip` tokens). Unfortunately, unlikely it will be fixed because my fixing request was closed: https://github.com/antlr/antlr4/pull/3018
> mmm... not sure why my commits aren't signed Every commit should have a sign, for example: ``` Signed-off-by: Ivan Kochurkin ``` Also, is it possible to squash most part...
> I had automated this on my end, and it seems to no longer work.. Looks like so because not every commit has a sign.
> Typescript CI is very slow, but we can look into it later (it doesn't affect the runtime). Now I see a lot of ``` java.io.IOException: Failed to delete file:...
I don't see such errors in `dev` branch for JavaScript: https://github.com/antlr/antlr4/runs/8288355910?check_suite_focus=true It affects CI servers since test data is not being removed and may take a lot of resource.