Ivan Kochurkin

Results 260 comments of Ivan Kochurkin

Some issues should be fixed before merging.

Could you please fix merge conflicts?

Thank you for the contribution and welcome to ANTLR grammars repository!

> Is there a specific reason for this, or just by accident? I think the second reason is correct. There was no user who suggested F# grammar.

Yes, we are always welcome for new contributors.

> I glanced over the implementation of other languages and fear, this is overwhelming to me grimacing What do you mean under the implementation? The current repository contains only grammars.

> Why in the world would a "quoted_string" --- things with quotes! -- ever, ever, ever derive a "variable_name"?? [here](https://github.com/antlr/grammars-v4/blob/a2fc801e2913e1b6f068b8ee541e21d1bccbcd01/sql/plsql/PlSqlParser.g4#L4602). This is complete nonsense, done [here](https://github.com/antlr/grammars-v4/commit/e3732b4379254cd64799f51bc4110702182788cc). Sorry, it was merged...

What methods are you going to benchmark?

Also, please merge your changes from different requests to the single one. I see you suggested several merge requests with sequential changes.

Could you please a sample that covers suggested changes or extend existing in https://github.com/antlr/grammars-v4/tree/master/sql/hive/v2/examples ?