Kudo Chien comments

Results 382 comments of


                                            Kudo Chien

Modify project plist for decorated icons during build time

Thanks and take your time.

Strict mode compatibility

This [codesandbox](https://codesandbox.io/s/react-virtualized-list-with-width-100-dunc2) example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

[expo][metro-config] proxy NativeModules to add better error handling in dev clients

i don't really like to replace the NativeModules export and try to seek for other possibilities. these's one maybe worth to take a look. #18064's approach makes sense to me....

[autolinking] Fix node resolution error when executed from scripts

> I could see this changing breaking the behavior of Volta specifically. For example, if a project's package.json contains `"volta": { "node": "16.6.0" }`, the developer generates .xcode.env.local, and then...

[autolinking] Fix node resolution error when executed from scripts

thanks! i'm going to land this fix.

[autolinking] Fix node resolution error when executed from scripts

@hirbod oh no. could you share the detailed build log? i would like to know which build phase scripts caused the problem. thanks!

[android][tools] Fix standalone build for sdk 46

will create a pr to remove skia entirely for classic build. i'm going to close this pr.

[Android][expo-splash-screen] No longer working without call to SplashScreen.show(...) on [email protected]

hi @thespacemanatee! could you help to create a minimal reproducible example and upload to a github repository? i tested on a new sdk 45 project and it works for me....

[secure-store] require biometrics on iOS with `requireAuthentication` to match Android implementation

sorry i missed this pr. i'll take a look soon.

[secure-store] require biometrics on iOS with `requireAuthentication` to match Android implementation

> @Kudo after a bit of searching I found my old phone in a drawer, which is running Android 11. And on this device `setUserAuthenticationRequired` in expos implementation is actually...