react-virtualized Strict mode compatibility

trafficstars

RV makes use of findDOMNode in WindowScroller and that's deprecated in recent versions of react. You might want to switch this to using refs instead. :)

Mar 28 '19 16:03 NeoLegends

@bvaughn can this be addressed? Concurrent mode is coming and it'd be nice if the library worked smoothly with it.

Aug 10 '19 17:08 Ericnr

It also seems to be used in CellMeasurer

Aug 14 '19 15:08 jktravis

In WindowScroller, it can be avoided by using registerChild render prop

I'm going to open a PR adding the same pattern for CellMeasurer

UPD: #1477

Dec 30 '19 22:12 Hypnosphi

Even if I use registerChild, WindowScroller doesn't seem to work with StrictMode:

https://codesandbox.io/s/react-virtualized-list-with-width-100-dunc2

You can see that if you scroll list down, new items don't appear. This can mean that there are side effects in places where they shouldn't be

https://reactjs.org/docs/strict-mode.html#detecting-unexpected-side-effects

Jan 10 '20 01:01 Hypnosphi

Thanks for bringing this up! I kinda lost track of some bugs. Will prioritize!

Jan 10 '20 03:01 wuweiweiwu

Would be awesome to get the strict mode issue fixed. Thanks for the great work so far!

Jan 14 '20 13:01 makker

Hello! Are there any news on this one? Would be awesome to get rid of those warnings cluttering the console :). Thank you for the effort and the nice library!

Apr 21 '20 10:04 HeikkiMoilanen1

I'd appreciate a fix for this. Thanks for great work!

Apr 21 '20 11:04 mika-kaki

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

Sep 03 '20 03:09 Kudo

This codesandbox example seems to be fixed after upgrading to RV 9.22, maybe it is related to #1477

This codesandbox isn't working as of 30/09/20. New items are not being rendered

Sep 30 '20 12:09 kierancrowntrt

Also keen to see a fix for this. We use react-virtualized and are considering trialing React concurrent and I'm not sure if this will just be an annoyance or cause actual errors.

Apr 23 '21 20:04 timminata

Not sure, why need findDOMNode() here if we already have ref there?

https://github.com/bvaughn/react-virtualized/blob/e360d958b99fa965fd3f1caed4506403ad652cd3/source/Table/Table.js#L342

Sep 12 '21 13:09 sergeyzwezdin

Not sure, why need findDOMNode() here if we already have ref there?

https://github.com/bvaughn/react-virtualized/blob/e360d958b99fa965fd3f1caed4506403ad652cd3/source/Table/Table.js#L342

A simple workaround would be const Grid = this.Grid._scrollingContainer;

Oct 25 '21 09:10 reliveyy

@bvaughn please take a look at this problem. It is annoying and takes up space when seeing it at the browser's console. And we can't suppress this warning too.