Krishna comments

Results 370 comments of


                                            Krishna

[$250] [Auth Violations] Support isDismissed on newDot to hide violations

@pecanoro after we dismiss the smartscan fail violation from OldDot and enter the details manually, a new warning type violation is received `receiptNotSmartScanned`. Is this expected? https://github.com/user-attachments/assets/32056ef0-0c3c-4b0e-b900-78aa5e70947c

[$250] [Auth Violations] Support isDismissed on newDot to hide violations

@pecanoro @rojiphil , do I need to record all the listed violations, or is recording only `SMARTSCAN_FAILED` sufficient? 1. DUPLICATED_TRANSACTION 2. SMARTSCAN_FAILED 3. RTER

[HOLD for payment 2024-12-07] [$125] Update the intent video for `Get paid back from my employer`

## Proposal  ### Please re-state the problem that we are trying to solve in this issue. Update the intent video for Get paid back from my employer ### What is...

[HOLD for payment 2024-12-07] [$125] Update the intent video for `Get paid back from my employer`

@anmurali, we need to upload the new video to `https://d2k5nsl2zxldvw.cloudfront.net/` and then we can replace the url below with the new one. Or if we have already uploaded the video...

[HOLD for payment 2024-12-07] [$125] Update the intent video for `Get paid back from my employer`

@anmurali, we need the url of the video uploaded to cloudfront. like [this one](https://github.com/Expensify/App/blob/3540a3b3c05fa6a7c30633bbb9c3eaf3dbe1054e/src/CONST.ts#L89).

[HOLD for payment 2024-12-07] [$125] Update the intent video for `Get paid back from my employer`

@abdulrahuman5196, PR ready for review ^

[$500] MEDIUM: Add email address to hover state of chat switcher results

### Proposal ### Please re-state the problem that we are trying to solve in this issue. MEDIUM: Add email address to hover state of chat switcher results ### What is...

[$500] MEDIUM: Add email address to hover state of chat switcher results

@c3024, I believe the inconsistency should be fixed here, we should be showing tooltips on hovering on the names when we don't have logins as subtitle. https://github.com/Expensify/App/assets/85894871/7c899119-9fe5-4754-8fa1-92d6a5684e50

[$500] MEDIUM: Add email address to hover state of chat switcher results

@c3024, any updated here?

[HOLD for payment 2024-12-17] Distance - No error when editing the default rate to 4 decimal places and creating a same one

@MariaHCD, I'll handle this as a follow-up 🙂 and will likely raise the PR by the end of the day.