[HOLD for payment 2024-12-17] Distance - No error when editing the default rate to 4 decimal places and creating a same one

[IuliiaHerets]

If you haven’t already, check out our contributing guidelines for onboarding and email [email protected] to request to join our Slack channel!

---

Version Number: 9.0.70-0 Reproducible in staging?: Y Reproducible in production?: N If this was caught on HybridApp, is this reproducible on New Expensify Standalone?: Y Issue was found when executing this PR: https://github.com/Expensify/App/pull/53104 Email or phone of affected tester (no customers): [email protected] Issue reported by: Applause Internal Team

Action Performed:

1. Go to staging.new.expensify.com
2. Go offline.
3. Create a new workspace.
4. Go to More features > Enable Distance rates.
5. Go to Distance rates.
6. Click on the default rate.
7. Change the rate to 1.00 and save it.
8. Click Add rate.
9. Try to save the same rate 1.00 and note that it shows error.
10. Click on the default rate.
11. Change the rate to 1.2345 (any four decimal places) and save it.
12. Click Add rate.
13. Create a new rate same as 1.2345 in Step 11 and save it.

Expected Result:

There should be error when saving the same distance rate.

Actual Result:

There is no error when editing the default rate to 4 decimal places and creating a new one of the same value. This issue is only reproducible in offline mode.

Workaround:

Unknown

Platforms:

• [x] Android: Standalone
• [x] Android: HybridApp
• [x] Android: mWeb Chrome
• [x] iOS: Standalone
• [x] iOS: HybridApp
• [x ] iOS: mWeb Safari
• [x] MacOS: Chrome / Safari
• [x] MacOS: Desktop

Screenshots/Videos

https://github.com/user-attachments/assets/bd595e57-90a9-4a72-b1e7-689d4eacef1e

View all open jobs on GitHub

Issue Owner

Current Issue Owner: @muttmuure

[melvin-bot[bot]]

Triggered auto assignment to @MariaHCD (DeployBlockerCash), see https://stackoverflowteams.com/c/expensify/questions/9980/ for more details.

[melvin-bot[bot]]

Triggered auto assignment to @muttmuure (Bug), see https://stackoverflow.com/c/expensify/questions/14418 for more details. Please add this bug to a GH project, as outlined in the SO.

[melvin-bot[bot]]

💬 A slack conversation has been started in #expensify-open-source

[github-actions[bot]]

:wave: Friendly reminder that deploy blockers are time-sensitive ⏱ issues! Check out the open `StagingDeployCash` deploy checklist to see the list of PRs included in this release, then work quickly to do one of the following:

1. Identify the pull request that introduced this issue and revert it.
2. Find someone who can quickly fix the issue.
3. Fix the issue yourself.

[IuliiaHerets]

Production

https://github.com/user-attachments/assets/08b6f0df-23f0-4152-afa5-e4027c5a23d0

[MariaHCD]

This can be a follow up improvement to https://github.com/Expensify/App/pull/53104

Not a deploy blocker since this validation was just introduced and looks to work well aside from 4 decimal places.

[MariaHCD]

cc: @Krishna2323 can you take this on as a follow up to https://github.com/Expensify/App/pull/53104?

[Krishna2323]

@MariaHCD, I'll handle this as a follow-up 🙂 and will likely raise the PR by the end of the day.

[Krishna2323]

@DylanDylann, please review the PR ^ when you have a chance. Its a regression from https://github.com/Expensify/App/pull/53104

[melvin-bot[bot]]

Reviewing label has been removed, please complete the "BugZero Checklist".

[melvin-bot[bot]]

The solution for this issue has been :rocket: deployed to production :rocket: in version 9.0.73-8 and is now subject to a 7-day regression period :calendar:. Here is the list of pull requests that resolve this issue:

• https://github.com/Expensify/App/pull/53610

If no regressions arise, payment will be issued on 2024-12-17. :confetti_ball:

For reference, here are some details about the assignees on this issue:

• @Krishna2323 requires payment (Needs manual offer from BZ)

[melvin-bot[bot]]

@MariaHCD @muttmuure @Krishna2323 The PR fixing this issue has been merged! The following checklist (instructions) will need to be completed before the issue can be closed. Please copy/paste the BugZero Checklist from here into a new comment on this GH and complete it. If you have the K2 extension, you can simply click: [this button]

[melvin-bot[bot]]

Payment Summary

Upwork Job

• ROLE: @Krishna2323 paid $(AMOUNT) via Upwork (LINK)

BugZero Checklist (@muttmuure)

• [ ] I have verified the correct assignees and roles are listed above and updated the neccesary manual offers
• [ ] I have verified that there are no duplicate or incorrect contracts on Upwork for this job (https://www.upwork.com/ab/applicants//hired)
• [ ] I have paid out the Upwork contracts or cancelled the ones that are incorrect
• [ ] I have verified the payment summary above is correct

[muttmuure]

@Krishna2323 please apply here: https://www.upwork.com/jobs/~021869894292678828379

[muttmuure]

$250 for @Krishna2323

[melvin-bot[bot]]

@MariaHCD, @muttmuure, @Krishna2323 Whoops! This issue is 2 days overdue. Let's get this updated quick!

[muttmuure]

Please post in the open source channel in Slack when you are ready to accept the contract for this

[DylanDylann]

@muttmuure Should I be eligible for compensation because I reviewed the PR

[muttmuure]

Yes you should

[muttmuure]

$250 @DylanDylann for C+

[DylanDylann]

$250 @DylanDylann for C+

@muttmuure Would you mind sending me an offer? https://www.upwork.com/freelancers/~010c6310ab55f3d17d

Thanks

[Krishna2323]

@muttmuure, my offer has also expired. Please send me one as well.

This can be a follow up improvement to https://github.com/Expensify/App/pull/53104

@MariaHCD, I just wanted to confirm before receiving a payment—am I eligible for payment or not? As you mentioned, this can be handled as an improvement instead of regression fix. Thanks!

[MariaHCD]

This was a regression within the regression period so I do not think any payments are required for this one