Krishna
Krishna
@dukenv0307, My solution was the same from initial proposal, I just added change in root cause and removed some extra changes that we don't require. You can check my initial...
@dukenv0307, you can clearly see thats a pseudo-code and below that I already mentioned about updating `updateGeneralSettings`, I already mentioned that I updated root cause. BTW you posted your solution...
https://github.com/Expensify/App/issues/37254#issuecomment-1983810198, I posted this because I updated the root cause and I agree that at first my root cause was not 100% correct but partially it was. The solution remained...
@dukenv0307, that's not a fair evaluation, I already agreed many times that I made change in the root cause and I even posted `Proposal Updated` after updating, and in my...
Proposal police clearly mentions the change was in the RCA, pls don't use incomplete sentences. > significant proposal change detected (RCA) **_Before update:_** `We update the pendingFields of the policy...
@s77rt, fix for `ReportParticipantsPage` added.
@hayata-suenaga [see comment](https://github.com/Expensify/App/pull/40136#discussion_r1562141173)
@hayata-suenaga, thanks for the explanation, will check that soon and update.
@kubabutkiewicz, thanks a lot for the heads up. I'll check this ASAP.
@alitoshmatov, Thanks for the review 🤠, I need to fix unit test, will do in a hour.