Tomasz Chabora

Results 934 comments of Tomasz Chabora

> Disk cache is deleted after successful load. It saves on editor exit, if successfully loaded/regenerated previously. Why? When you don't modify it, it re-saves for no reason. You could...

> We don't have a way to change only part of the file, so the entire disk cache will be invalidated whenever any single script is saved. Yeah but until...

Tested with my very big projectâ„¢ and the editor is stuck on reopening scenes: ![image](https://github.com/user-attachments/assets/6d0664a4-68b5-492b-b3c5-391e796eed0b) It's one of the initial steps when launching. Maybe something gets locked by the thread?

Stuck trace: ``` Thread::wait_to_finish() Line 87 (c:\godot_source\core\os\thread.cpp:87) EditorHelp::_wait_for_thread() Line 2866 (c:\godot_source\editor\editor_help.cpp:2866) EditorHelp::get_doc_data() Line 3329 (c:\godot_source\editor\editor_help.cpp:3329) Shader::get_shader_uniform_list(List * p_params, bool p_get_groups) Line 177 (c:\godot_source\scene\resources\shader.cpp:177) ShaderMaterial::_get_property_list(List * p_list) Line 234 (c:\godot_source\scene\resources\material.cpp:234) ShaderMaterial::_get_property_listv(List...

I noticed the same problem in some other classes.

Yeah editor has auto-translation enabled, but all strings are set pre-translated. We could be using TTRC almost everywhere.

It could be useful for plugins, once we support translating them.

I think `handles()` takes a whole object to allow filtering objects by more than only a type (although it's not really used in practice). You can use this trick to...

I see some faulty logic in `_get_valid_conversions_for_file_paths()`. It returns empty Vector when it encounters any problem, but otherwise it will happily dump every plugin into one vector. The plugins might...

Found a bug: if there are multiple conversion options, the first one in the list will always be used regardless of what you select. I wrote some dumb custom plugin...