KevinOConnor
KevinOConnor
@cmroche - fyi. -Kevin
Thanks. Seems fine to me. I'll give a few days to see if there are any other comments. -Kevin
I made a change in a8cbc935 which adds the same simple check found in `MCU_SPI_from_config()`. It's fine to improve the default for `mcu_i2c` when using software i2c, but if so...
FWIW, I'm not sure about this PR. It seems to be adding a bit of complexity to the "main path" for an uncommon error. Cheers, -Kevin
> I somewhat lean towards integrating the tap into the existing setup/query home for ldc1612, to reduce overall command count footprint. Do you mind? (Current approach easier for testers in...
Thanks. I think it would be good to merge this support. There are a couple of things I noticed while reviewing: * I think it would be good if we...
Okay, thanks. I'll commit when you are ready. > trigger_analog: Don't remote trigger time as the peak time Oops - I goofed - that should have been "trigger_analog: Don't report...
Thanks. -Kevin
Thanks. It's fine with me. Let me know when you think it is ready to be merged. -Kevin
The homing code has some issues today. There was a discussion on this a few months back - https://klipper.discourse.group/t/thoughts-on-homing-support-in-klipper/22737 . I'm a little leery about making incremental changes like this...