Create printer-sovol-sv06-2022.cfg

[spinixguy]

configuration file for sovol sv06 printer

[manu7irl]

Why removing the thermistor? This a none standard one in use to get readings up to 300 degrees C. Can someone explain why a stock thermistor should be used instead? Would this not effect the readings from it?

On Thu, Jan 19, 2023, 6:48 PM spinixguy @.***> wrote:

@.**** commented on this pull request.

In config/printer-sovol-sv06-2022.cfg https://github.com/Klipper3d/klipper/pull/5998#discussion_r1081546066:

+rotation_distance: 4 +endstop_pin: probe:z_virtual_endstop +position_min: -4 +position_max: 261 +homing_speed: 4

+[tmc2209 stepper_z] +uart_pin: PA15 +run_current: 1.000 +stealthchop_threshold: 40 +interpolate: False +sense_resistor: 0.150 +uart_address: 3 +diag_pin: PA7 + +[thermistor sovol_thermistor]

thermistor section removed.

— Reply to this email directly, view it on GitHub https://github.com/Klipper3d/klipper/pull/5998#discussion_r1081546066, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAWT4RBDYRGRRI55DKZB3QLWTFV6BANCNFSM6AAAAAAT7XLQCA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

[Fisheiyy]

Why removing the thermistor? This a none standard one in use to get readings up to 300 degrees C. Can someone explain why a stock thermistor should be used instead? Would this not effect the readings from it?

In what way is it non standard? The thermistor section he defined looked very similar to that of a generic epcos 100k or even a 104-gt2 which is rated to 300C

[Fisheiyy]

Why removing the thermistor? This a none standard one in use to get readings up to 300 degrees C. Can someone explain why a stock thermistor should be used instead? Would this not effect the readings from it?

In what way is it non standard? The thermistor section he defined looked very similar to that of a generic epcos 100k or even a 104-gt2 which is rated to 300C

Looking at the sovol marlin github it shows they are using the thermistor type that is best for a epcos 100k and the max temp is limited to 275

[spinixguy]

Thank you for submitting a config for the repo.

Please make this can build properly, you currently have whitespace errors failing the checks.

You need to refer to https://github.com/Klipper3d/klipper/blob/master/docs/Example_Configs.md and espcially point 4 for adding the regression test.

You also need to sign off your config according to https://github.com/Klipper3d/klipper/blob/master/docs/CONTRIBUTING.md

Thanks James

James, i think I have all the issues sorted out.

[spinixguy]

Thank you for the changes you have submitted. I have one last comment. You should not be setting anything other than 0 or 999999 for stealthchop_threshold as per the documentation at https://github.com/Klipper3d/klipper/blob/master/docs/TMC_Drivers.md#setting-spreadcycle-vs-stealthchop-mode unless you have a very good reason to do this, it is not recommended in klipper

Thanks James

Updated.

[github-actions[bot]]

Thank you for your contribution to Klipper. Unfortunately, a reviewer has not assigned themselves to this GitHub Pull Request. All Pull Requests are reviewed before merging, and a reviewer will need to volunteer. Further information is available at: https://www.klipper3d.org/CONTRIBUTING.html

There are some steps that you can take now:

1. Perform a self-review of your Pull Request by following the steps at: https://www.klipper3d.org/CONTRIBUTING.html#what-to-expect-in-a-review If you have completed a self-review, be sure to state the results of that self-review explicitly in the Pull Request comments. A reviewer is more likely to participate if the bulk of a review has already been completed.
2. Consider opening a topic on the Klipper Discourse server to discuss this work. The Discourse server is a good place to discuss development ideas and to engage users interested in testing. Reviewers are more likely to prioritize Pull Requests with an active community of users.
3. Consider helping out reviewers by reviewing other Klipper Pull Requests. Taking the time to perform a careful and detailed review of others work is appreciated. Regular contributors are more likely to prioritize the contributions of other regular contributors.

Unfortunately, if a reviewer does not assign themselves to this GitHub Pull Request then it will be automatically closed. If this happens, then it is a good idea to move further discussion to the Klipper Discourse server. Reviewers can reach out on that forum to let you know if they are interested and when they are available.

Best regards, ~ Your friendly GitIssueBot

PS: I'm just an automated script, not a human being.

[KevinOConnor]

Thanks. Looks fine to me, but it needs a rebase as github shows this PR as having a conflict.

-Kevin