code_gs

Results 229 comments of code_gs

This is tested. The diff always tries to condense the changes, so it will grab an end from an unrelated function if there's no additions between, which is the case...

Conflicts resolved

What needs to be done to see this change merged?

I mean other than that. It sat for years without conflict.

1. You should not bundle unrelated changes together. 2. You should mention that this PR is reliant on your other Vector PR. 3. You should probably make the name GetOrghogonalVector...

You still need to remove unrelated changes. This PR should only contain the GetOrthogonalVector addition, nothing else.

Also, you need to fix the code styling to match the rest of the codebase.

The ``util`` library is the best place for it. ``math`` is currently for numbers, and it doesn't make sense in the Vector metatable since it modifies arguments and it's ambiguous...

Put it into a separate PR. Also, you still need to fix the style.

Look around the file. There should be spaces surrounding parentheses (``if ( bN ) then``), and there should be empty lines surrounding control-statements, in this case, ``if`` and ``end``.