Tomaz Muraus

Here is an example of Dockerfile based on ``nextcloud:fpm-alpine`` image which I use for ``cron`` service in my docker compose setup which is working correctly. ```dockerfile FROM nextcloud:fpm-alpine # Add...

I'm fine with switching to ``ciso8601`` or a similar alternative which is (actively) maintained and support. In fact, as you said cisto8601, may even be better choice for multiple reasons....

Overall, I'm fine with the change, but some tests would be good :)

Thanks for the contribution. The change overall seems reasonable (I will add in-line code comments later), but can you please provide some context and background on this change?

This looks like a useful functionality, but it think it would make more sense / be more useful if this value could also be provided / overridden on action basis...

You need to copy the pack content to the st2actionrunner container - that's where the actions run on. In addition to that, you also need to run st2-register-content in that...

This can already be done using Python packages (you can publish re-usable code to PyPi / private registry / similar) which can than be shared by various packs and listed...

I won't have time to perform a detailed review, but just two quick comments / questions: 1. Performance implications It appears that depending on the object passed to the function,...

IIRC, ``ST2_ACTION_AUTH_TOKEN`` was never set for the unit tests and they way to test client / datastore functionality is to use mock datastore client (``st2tests.mocks.datastore.MockDatastoreService``). That method only mocks datastore...

Update - I had a look at https://github.com/StackStorm-Exchange/stackstorm-msexchange/pull/16. It appears client is only used to manage datastore items - in this case it probably shouldn't be too hard for us...