Tomaz Muraus

Results 163 comments of Tomaz Muraus

Thanks for the contribution. As @blag pointed out, SHA1 is used for MAC and not for actual symmetric encryption. In theory, I'm fine with changing it, but in case we...

Yeah, I was wondering if using "raw" Jinja tag would work for both scenarios. So to confirm - if you use raw Jinja tag, it will only stop Jinja processing,...

@m4dcoder I tried to verify the behavior by adding a unit test (https://github.com/Kami/orquesta/commit/d134ba5c96b5910d7136e9c83eb79947dff737de) and it seems to be working fine for mixed expression scenarios, at least on the unit test...

@m4dcoder After some more digging in - I didn't really express my problem well enough above and ``raw`` template tag is not the most ideal solution for it. Let's imagine...

Thanks for the report / feature request. RBAC for ChatOps is indeed on our roadmap for this year, but we don't have an ETA for it yet. Only listening for...

I believe you also need to update ``st2common/st2common/openapi.yaml.j2``, specifically ``PacksInstall`` object and also the corresponding API handler code in ``st2api/st2api/controllers/v1/packs.py``.

Thanks for the contribution. Overall, I'm fine with this change, but as mentioned above, it needs some more work + ideally at least the unit test for the API layer...

Alright I pushed additional changes: * The change is now fully backward compatible not matter how you specify the data (command line argument with actual values, command line argument with...

@bojand Sorry for the delay - I some how missed your review feedback. I'll try to address this review feedback this weekend (I've been using those changes for a while...