Tomaz Muraus

Results 163 comments of Tomaz Muraus

Yeah, making some of those arguments optional seems reasonable to me. Adding ``None`` default value should be fine, we just can't move the method arguments around (change the method signature)...

I agree that this would be a good feature to have. Some drivers already implement this functionality via extension / ex_ arguments. As far as implementation goes - ideally we...

Great, thanks! Just curious is this official pricing endpoint any smaller? Or it's perhaps even bigger? Just curious since previous JSON we used to download was massive (multi GB) which...

I've added some inline comments / questions.

I've pushed some small lint and ``tox.ini`` fixes, but it looks like the script still fails with empty cache: ``` Traceback (most recent call last): File "contrib/scrape-ec2-prices.py", line 301, in...

EDIT: It looks like ``ijson.parse()`` takes a very long time already and then iteration over the parsed content. I don't think it's possible to add progress bar for ``ijson.parse()`` step...

I pushed some additional changes to increase buffer size to speed up parsing a bit and to print up a progress bar - since ``ijson`` handles parsing in an incremental...

@Eis-D-Z Script seems to be working now and other checks passing, but unit tests one is still failing - https://github.com/apache/libcloud/runs/7481787304?check_suite_focus=true It appears it's failing because the pricing.json file format has...

@Eis-D-Z How is this PR looking? Would be great if we could get it wrapped up merged. Thanks.

@Eis-D-Z Thanks! Since this change basically doubled the pricing file (from 2 MB to 3 MB), I will take some time to verify that it has no negative implications on...