Joshua Lückers - Jacobsen

Results 111 comments of Joshua Lückers - Jacobsen

I think we can solve this by adding a new class alias in `core/include/deprecated.php`. ``` class_alias(\MODX\Revolution\Sources\modMediaSource::class, \MODX\Revolution\modMediaSource::class); ``` See: https://github.com/modxcms/revolution/blob/f7bc0133f5f09184418a7ddf6f9b98a3f0decd9e/core/src/Revolution/modX.php#L2537

Great suggestions! The "Open in new window" button is really useful and, in my opinion, should be part of the final 3.0 release.

Are you sure the error is related to the password? Is there anything in the MODX and/or PHP error log?

> The tests have to be reverted too, since nested output filters don't work anymore (at least in the test). The code is reverted to the state before #14458. Yes...

@opengeek @Mark-H what are your thoughts on this?

> This approach attempts to keep things working along the same lines as 2.x, where it's writing the file outside of the media source (in modElement). @opengeek if it's in...

Feel free to contribute by submitting a PR😎👍

> Maybe that can be restricted to two starting dots: `#^(\.{2}|/)+#u` > > Should be safe: https://regex101.com/r/FbuRLQ/1 > > The dot files have to be restricted elsewhere. That's also how...

> Would you instead support a new section in the "troubleshooting installation" section of the documentation? @tvquizphd if you have to opportunity to do so, yes please update the documentation.

Since there is an agreement about this not being the best solution I will close this PR.