Joshua Lückers - Jacobsen

Results 111 comments of Joshua Lückers - Jacobsen

I'm able to reproduce this in 3.x.. I think the parser doesn't like the `:` and `;` in the `then` and `else` modifiers. If I replaced the `:` and removed...

This is where it goes wrong: https://github.com/modxcms/revolution/blob/697a0286117a7e30b19c7f78ef30803806daf6c3/core/src/Revolution/Filters/modInputFilter.php#L56 The pattern used in the `preg_match_all` needs to be fixed.

@intersel you should be able to back port the Unit Test from PR #16165 and additional test case I mentioned in the comment.

Just to recap, is this right? - The language is selected during setup (clean install) - Changing the language through the manager solves the issue

@Mark-H I think we can move forward with this!

> For 2.x, add a check in the config check dashboard widget. If installed on sqlsrv, show a warning their setup will not be supported in 3.x. While adding that,...

> Shouldn't be a massive change but especially the setup bit might be a bit of digging to find the right place that has access to the current config and...