revolution Revert and break nested output filters

Revert and break nested output filters

Open JoshuaLuckers opened this issue 1 year ago • 7 comments

What does it do?

Revert and break nested output filters to fix a lot of other issues with output filters introduced in PR #14458

Why is it needed?

To fix a lot of issues with output filters being broken.

Related issue(s)/PR(s)

Related issues:

#16044
#16186

Related PR: #14458

Aug 28 '22 11:08 JoshuaLuckers

The tests have to be reverted too, since nested output filters don't work anymore (at least in the test). The code is reverted to the state before #14458.

Aug 28 '22 22:08 Jako

The tests have to be reverted too, since nested output filters don't work anymore (at least in the test). The code is reverted to the state before #14458.

Yes you’re right, I hope to find some time to actually fix the issue but it’s complicated to do. Once everyone agrees with reverting the change and breaking nested output filters I’ll remove the breaking test cases.

Aug 29 '22 07:08 JoshuaLuckers

@opengeek @Mark-H what are your thoughts on this?

Aug 31 '22 11:08 JoshuaLuckers

I've not followed this issue closely enough to have a strong opinion, though it sounds like this may be related to some upgrade issues I've seen myself.

I'm seeing two integrators who have been working on this issue saying we need this, and am happy to lend those my support.

Maybe as the next step after this we can build a ton more extra test cases (some of which may fail for now) to make sure we avoid going back and forth on this repeatedly. Clearly there needs to be work on the parser but very few people are comfortable with this particular level of spaghetti and inferred behavior.