Jonathing
Jonathing
Force pushed to rebase on top of 1.21. Make sure to change the target branch of this PR.
Here's a patch of all the license violation fixes if you just want to apply it on top of your workspace. https://gist.githubusercontent.com/Jonathing/fdeec76c978dee9ae33e4d780b9b6f7f/raw/692c91a9a9f74cd5790217f5cc42fad460e48d04/license-violation-fixes.patch
Good morning. I have two new reviews for you. ## Tags Review I've decided to locally compile your PR, generate the data, and run it with our CommonTagsDumper. Everything looks...
This issue is becoming stale. If you're still interested, please send us a reproducible test case so we can try and fix whatever's causing this.
The write-ups are useful, but [like mentioned earlier](https://github.com/MinecraftForge/MinecraftForge/issues/9973#issuecomment-2113108713), having an isolated, reproducible test case is going to help us actually understand what the issue is with Forge and how we...
I mentioned this in #10417, but I wanted to also mention here that while we will be working on cleaning up the differences in Redstone between Forge and Vanilla, I...
If I were to backport this I *would* add a config option that is disabled by default. So that's probably what I would do. After all, server configs (are supposed...
What is the problem with boxed primitives in configs? It's not like this is rendering code.
I think that the final decision of whether this PR should be merged or not should be up to Lex. I can't speak on his personal feelings and experiences on...
I don't agree. While I use MixinExtras on my own projects, I don't want to get to a point where we just start bloating Forge more than it already has...