JohnnyMorganz

Results 416 comments of JohnnyMorganz

> To be clear, have you ever gotten this on release optimizations, or is that just theoretical? If so, then my potential fix likely won't help. https://github.com/JohnnyMorganz/StyLua/issues/38 was done using...

Just tested this now, and it seems to be working fine using a release version of StyLua, so maybe it is only for the debug version ![image](https://user-images.githubusercontent.com/19635171/110127799-f6552c00-7dbd-11eb-8b75-e862b296f707.png) I will ask...

I'm aware it exists, and I know the current workaround is just to use a release build instead. @Kampfkarren looked more into the underlying cause, and I think they pinpointed...

Was looking at this - this is more of a semantic issue rather than a syntactic one. Is this more suited to be handled by a downstream consumer, such as...

Separating into different crates and allowing custom parsers does sound interesting, and will definitely help with the Luau split. I know this is pretty theoretical right now, but I was...

This issue is also present for the following (listed here for reference in case this is relied upon by a downstream crate): - `TableConstructor` * - `Field::ExpressionKey` - `Index::Brackets` *...

> Some of these can be attributed to using the wrong attributes, i.e. not using `#[visit(contains = "...")]` or `#[node(full_range)]`, From what I can tell, the `#[visit(contains = "...")]` attribute...

My only gripe with converting it to explicit definitions would be that there is a significant amount of boilerplate/repeated code. I guess it could be abstracted out into some normal...

> I'd suggest we preserve chain line breaking. As I mention in https://github.com/JohnnyMorganz/StyLua/issues/78#issuecomment-1014688702, I want to try and avoid relying on input code to determine how to format something. I...

> I think break if multiple : would result in: > > ``` > local icon_widget = tab > :AddChild(ImageStore > :Get(IMAGES.icon) > :Large()) > :SetColor(Color > :Get(TEXT_LIGHT_ON_DARK)) -- does...