JohnnyMorganz comments

Results 416 comments of


                                            JohnnyMorganz

Turns readable multi-line function calls into harder to read, single line ones, but are under the column width

I definitely also prefer the former styling here, so this should be looked into. I think part of the reason for this problem is because of the way I set...

Turns readable multi-line function calls into harder to read, single line ones, but are under the column width

Just thought I'd let you know - you may find that the formatting is better for you if you reduce the column with (maybe to something like 80 or 100)....

Turns readable multi-line function calls into harder to read, single line ones, but are under the column width

I was looking at this further - and I realise that the first four screenshots you posted - they are all under the column width. I can fix the last...

Turns readable multi-line function calls into harder to read, single line ones, but are under the column width

> Function call which contains long concatenated string arguments are turned into single line. Can this be fixed? > > > > For example > > ``` > > error("11111111111111111111111111111111111111111111111"...

Turns readable multi-line function calls into harder to read, single line ones, but are under the column width

> Change the rule to take the current state into account: > > * if a function call is currently broken after each argument I'm a bit wary about relying...

Optional parentheses: keep on foo('bar')(baz)

Hm, personally I do agree that I prefer the former style compared to the latter. My main concern right now is how much of an impact it will have on...

Optional parentheses: keep on foo('bar')(baz)

@Dionysusnu definitely a valid point. I know also that sumneko's lua language server (not that its formatted with stylua, but just as an example) uses a custom DSL like ```lua...

Optional parentheses: keep on foo('bar')(baz)

> I think this should be a separate option. For example, in the Fusion codebase, there are a lot of cases of `Instance.new("Folder")`, which we want to keep with parentheses....

Optional parentheses: keep on foo('bar')(baz)

> I'm wondering if it's worth having an option to leave them as-is and instead leave this question of which to use to be answered by style guides and coding...

Optional parentheses: keep on foo('bar')(baz)

Just wanted to point out (for anyone following this) about the addition in #330 over more granular control over when parentheses are removed. It allows to optionally only remove parentheses...