JohnnyMorganz

Results 416 comments of JohnnyMorganz

No problem, as mentioned earlier, testing for CurrentlyCleaning is sufficient for my use case. If it's of any help, you might find a LinkedHashMap-like struct useful for this

An example, in Lua ```lua foo( -- comment "bar" ) ``` I want this to be collapsed onto a single line, but I can't add a hardline at the end...

Hm, I've been rethinking this and I actually do agree with you there - I should probably be leaving comments as close to where they are originally. I guess another...

Alright, I'll check it out and see how I get on (it may be a while as I'm currently working on some other stuff right now). Thanks!

We could potentially also get rid of the `roblox` ignore on this test: https://github.com/Kampfkarren/full-moon/blob/19f98b778531e2d5d807d979bba6996040df2042/full-moon/tests/pass_cases.rs#L56-L60 Will need a bit more snapshot cleaning though. Let me know if I should do that

Yeah it would have (I deleted the test and put it in the other PR) The Lua 5.1 tests are ignored though, so they might not be picked up

Wherever we do `.len()` on a string we should probably compute graphemes. Will probably need to bring in an external crate for this

Yeah, I forgot to update it this release, so unfortunately had to do it in a commit aftwards. Will try to fix this

This has been fixed for 0.15.0 and future releases. I've added some checks to ensure this doesn't happen again, so I'll close this issue now. Let me know if anything...

I don't actually use the precommit hook so not sure what the issue is here. It sounds like this might actually be a problem with precommit? If it only searches...