Johannes Lorenz

Results 288 comments of Johannes Lorenz
trafficstars

From a code perspective, no complaints against this (but testing would not harm). Note that in the recent days, I merged a few commits to calf's master, and there may...

@davidovski If you want to get this merged, it would be nice if you could fix PhysSong's comment and solve the merge conflict.

> The discussion I was thinking of was #5062. The vote was 7-1 in favour of users ignoring their IDE files locally. Restricting to users who appear on [the contributor...

> I think this is even more valuable in the light of attracting new contributors who might not be so experienced and who might be intimated by long lists of...

The caption is a bit misleading? While this is a reverter which *re-uses* the Comb Filter code, it is not a comb filter? A filter would usually have a frequency...

Given the already large size of the PR, I wonder if it would be better to split the doc part into a separate PR that we merge before this PR?...

Btw, it's not urgent, but @friedolino78 @fundamental feel free to review this concept.

@michaelgregorius You often do very explanative commit messages, which is very valuable. However, some of the commits in your PRs have long commit messages without newlines. `gitk` does not break...

It should be noted (also in the headline of this PR) that this only affects RemotePlugin based mono plugins (at least, LADSPA and Lv2 are currently not affected).

> It should be noted (also in the headline of this PR) that this only affects RemotePlugin based mono plugins Well, if you plan to do it for all, the...