Joel Speed

Results 943 comments of Joel Speed

/override ci/prow/verify-crd-schema Only incorrectly identified newly required fields (they have optional parents)

I think the solution to the issue is in this comment, https://github.com/oauth2-proxy/oauth2-proxy/issues/1795#issuecomment-1268068852 You need to create a list of possible groups, then you can restrict from there using the query...

Verify looks like there's a need to re-run the update scripts? Diff in the generated CRDs

/test minor-images /test e2e-aws-ovn-hypershift /test e2e-upgrade

/override ci/prow/verify-crd-schema False positives on `NoNewRequiredFields`, the parent of these fields is optional and omitempty, therefore the new required field is not a breaking change for existing clients

Huh, why did the integration test fail now? 🤔