openshift
SPLAT-1743: vSphere - add host and vm based zonal
Changes
- New feature gate
VSphereHostVMGroupZonal - Add
RegionTypeandZoneTypefields toVSpherePlatformFailureDomainSpecto specify region and zone failure domain types. - Add
VSphereFailureDomainAffinitytype that contains three fields required for vm-host zonal:VMGroup,HostGroupandVMHostRule. - Add
VSphereFailureDomainAffinitytoVSpherePlatformTopology - Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
- Add
VMGroupin a machine(s) workspace.
Additional PRs
-
https://github.com/openshift/enhancements/pull/1677
-
https://github.com/openshift/installer/pull/8873
-
https://github.com/openshift/client-go/pull/294
-
https://github.com/openshift/library-go/pull/1782
-
https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325
-
https://github.com/openshift/machine-api-operator/pull/1285
-
https://github.com/openshift/api/pull/1999
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all
![openshift-ci[bot] avatar](https://avatars.githubusercontent.com/in/91280?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hello @jcpowermac! Some important instructions when contributing to openshift/api: API design plays an important part in the user experience of OpenShift and as such API PRs are subject to a high level of scrutiny to ensure they follow our best practices. If you haven't already done so, please review the OpenShift API Conventions and ensure that your proposed changes are compliant. Following these conventions will help expedite the api review process for your PR.
(will re-write the commit message with appropriate details once this PR is closer to being ready)
/test build /test e2e-aws-ovn
/test e2e-aws-ovn-techpreview
/test e2e-upgrade /test e2e-upgrade-minor /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
/test build /test images /test integration /test unit /test verify /test verify-client-go /test verify-crd-schema /test verify-deps
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Changes
Additional PRs
https://github.com/openshift/api/pull/1999 https://github.com/openshift/installer/pull/8873 https://github.com/openshift/client-go/pull/294 https://github.com/openshift/library-go/pull/1782 https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 https://github.com/openshift/machine-api-operator/pull/1285
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Changes
Additional PRs
https://github.com/openshift/enhancements/pull/1677 https://github.com/openshift/api/pull/1999 https://github.com/openshift/installer/pull/8873 https://github.com/openshift/client-go/pull/294 https://github.com/openshift/library-go/pull/1782 https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 https://github.com/openshift/machine-api-operator/pull/1285
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Changes
- New feature gate
VSphereHostVMGroupZonal- Add
RegionTypeandZoneTypefields toVSpherePlatformFailureDomainSpecto specify region and zone failure domain types.- Add
VSphereFailureDomainAffinitytype that contains three fields required for vm-host zonal:VMGroup,HostGroupandVMHostRule.- Add
VSphereFailureDomainAffinitytoVSpherePlatformTopology- Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
Additional PRs
https://github.com/openshift/enhancements/pull/1677 https://github.com/openshift/api/pull/1999 https://github.com/openshift/installer/pull/8873 https://github.com/openshift/client-go/pull/294 https://github.com/openshift/library-go/pull/1782 https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325 https://github.com/openshift/machine-api-operator/pull/1285
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Changes
- New feature gate
VSphereHostVMGroupZonal- Add
RegionTypeandZoneTypefields toVSpherePlatformFailureDomainSpecto specify region and zone failure domain types.- Add
VSphereFailureDomainAffinitytype that contains three fields required for vm-host zonal:VMGroup,HostGroupandVMHostRule.- Add
VSphereFailureDomainAffinitytoVSpherePlatformTopology- Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
Additional PRs
https://github.com/openshift/enhancements/pull/1677
https://github.com/openshift/installer/pull/8873
https://github.com/openshift/client-go/pull/294
https://github.com/openshift/library-go/pull/1782
https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325
https://github.com/openshift/machine-api-operator/pull/1285
https://github.com/openshift/api/pull/1999
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@jcpowermac: This pull request references SPLAT-1743 which is a valid jira issue.
Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.18.0" version, but no target version was set.
In response to this:
Changes
- New feature gate
VSphereHostVMGroupZonal- Add
RegionTypeandZoneTypefields toVSpherePlatformFailureDomainSpecto specify region and zone failure domain types.- Add
VSphereFailureDomainAffinitytype that contains three fields required for vm-host zonal:VMGroup,HostGroupandVMHostRule.- Add
VSphereFailureDomainAffinitytoVSpherePlatformTopology- Create additional unit tests to cover the introduction of vm-host zonal provisioning types.
- Add
VMGroupin a machine(s) workspace.Additional PRs
https://github.com/openshift/enhancements/pull/1677
https://github.com/openshift/installer/pull/8873
https://github.com/openshift/client-go/pull/294
https://github.com/openshift/library-go/pull/1782
https://github.com/openshift/cluster-control-plane-machine-set-operator/pull/325
https://github.com/openshift/machine-api-operator/pull/1285
https://github.com/openshift/api/pull/1999
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.
@JoelSpeed this pr and the enhancement https://github.com/openshift/enhancements/pull/1677 are ready for review when you have a chance
@JoelSpeed https://github.com/openshift/api/pull/1999/commits/2ee822a5c01f76da9639f182fac153ab09df51c1 changes from our meeting earlier today
@JoelSpeed I pushed fe164067da0405e64fcbc4cd73d38f09b1a11a7e with changes to CEL, required fields and MinLength. Included some additional unit tests.
Verify looks like there's a need to re-run the update scripts? Diff in the generated CRDs
Verify looks like there's a need to re-run the update scripts? Diff in the generated CRDs
It looks like I needed to rebase, just pushed
/override ci/prow/verify-crd-schema
False positives on NoNewRequiredFields, the parent of these fields is optional and omitempty, therefore the new required field is not a breaking change for existing clients
@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/verify-crd-schema
In response to this:
/override ci/prow/verify-crd-schema
False positives on
NoNewRequiredFields, the parent of these fields is optional and omitempty, therefore the new required field is not a breaking change for existing clients
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.