Joel Speed

Results 943 comments of Joel Speed

/hold Not clear to me what we are actually trying to achieve here. This is demoting the feature, I expect you actually want to promote the feature. Looking at the...

> IMO we could also add a metric for A/B testing in beta (cc @JoelSpeed)? I would like to avoid missing the PRR freeze because of that :D I'm happy...

Do we need to consider the ordering in flattening? CRD validations are executed in order so do we think the field level validations or the struct level validations should come...

> Ultimately, I don't think the order can affect the correctness or the cost budget for the validations as they are all executed even after a failed rule. Is that...

@aojea What's the next step here, is there a need for a conversation deciding between this and the revert approach?

Yes I think we may want to take a leaf out of KCMs book here and not immediately flick to the unready state. I would expect in the real world...

Seems like a reasonable feature request to me, and something we should be supporting in the longer term, do you have time to take a stab at implementing this?

/override ci/prow/verify-client-go As with every rebase, this won't pass and we have to override, will be restored once the rebase of client-go is merged