Joel Speed
Joel Speed
OpenAPI generation needs to be updated, but otherwise LGTM
/lgtm /label acknowledge-critical-fixes-only Docs only change
I don't understand why casing is an issue here? OpenShift APIs should use PascalCase, no matter what the underlying API uses. We control where we are using this code and...
I'm not sure it's quite that simple, IIUC, lots of areas assume that there is an email beyond the OIDC provider code. I think in the future we would like...
/override ci/prow/verify-crd-schema
/test verify-feature-promotion Just need to borrow a PR that promotes a feature gate to check this CI check is working as expected
> @JoelSpeed I'll leave it up to you, but I noticed that there aren't any tests added for the new fields and validations - is that something we require for...
Tests are documented in https://github.com/openshift/api/tree/master/tests An example would be to add a file alongside the other tests with your FG name and then add some additional cases specific to your...
Isn't there only 1 rule on top of the container resources ones? Generally I'd expect tests for each so that we can see if stuff that previously worked stops working...
I think this LGTM if we can squash the commits