Joel Speed
Joel Speed
/override ci/prow/verify-crd-schema We can't fix the existing NoBool issues
LGTM once the auth team ack /override ci/prow/verify-crd-schema
It's not clear to me why we would prefer to use an annotation (which is unversionable and has no schema) over a field that can be declared, versioned, checked using...
> we can eliminate ClusterProfileName("include.release.openshift.io/ibm-cloud-managed") Is the annotation used at all by ROKS? Is eliminating this actually a good idea?
Is this causing issues currently or is it just a security note? How hard would it be to implement this change? Can you raise a PR?
> But this also allows them to access the internal files that oauth2-service writes to state directory. What files are you referring to? To my knowledge, OAuth2 Proxy writes no...
Is this a duplicate of/related to https://github.com/oauth2-proxy/oauth2-proxy/issues/2536?
Ack, fair point, just trying to make a link since #2537 is supposed to fix #2536. Anyone able to test the proposed fix in their use case?
@anirudhAgniRedhat Yes I think so, are the other PRs ready to go? Do you think if we merge this now we will be able to get all PRs into a...