Jelte Fennema-Nio
Jelte Fennema-Nio
> The big issue is going to be making sure that a tokio runtime under PGX doesn't cause off-main multithreaded interactions with Postgres. Afaict that problem is solved by using...
Based on the tokio docs it seems acceptable, but not preferable: > Note: This macro can be used on any function and not just the main function. Using it on...
Could you change the base for this PR to the main? We normally merge everything into main and then cherry-pick to the release branches, but we didn't follow that approach...
Do you plan on addressing the review feedback, I'm considering maybe merging this in for 1.0 anyway if it's in a good state.
I think this is the same issue as reported in #396. PRs are definitely welcome to fix this.
How are you gathering these metrics? Is it through PgBouncer? i.e. maybe it's missing the metrics because it cannot connect anymore, instead of these metrics actually being 0.
Thanks a lot! This looks great. We're currently preparing for a 0.1.0 release, and given the size of the PR we probably don't want to squeeze it in before that...
Regarding the test failure in PG17, which happens due to a different error message in that PG version. The approach we take so far for cases like this is to...
> But find the test cases can pass now. Ah if it passes now you can disregard my comment.
I'm fine with this feature being added. I agree with @joshka that there are definitely situations where it's not an error when you cannot cast an enum variant to a...