Jelte Fennema-Nio comments

Results 685 comments of


                                            Jelte Fennema-Nio

Alternative (immutable) semantics: "insert on read"

Originally, I think I wanted to insert on reads as well. The problem was indeed that you only have a immutable reference, not an mutable one when calling `get`. From...

display: enum match arms: use 'Self' (to fix incompatibility with `#![deny(clippy::use_self)]`

I am not opposed to bumping MSRV to something less ancient, but I would like to do that only when increasing the major version of the library. Marking this lib...

Add a `default` and `value` attribute parameters

@ffuugoo @tyranron This is needed to make `Error` derives with a Backtrace really nice. Then you can do something like: ```rust #[derive(From, Error, Display)] struct SimpleError; #[derive(From, Error, Display)] #[display(fmt="Some...

Add a `default` and `value` attribute parameters

Possibly we would want this case to have a special syntax for usability, e.g. `#[from(backtrace_capture)]`

Add a `default` and `value` attribute parameters

Removing this from the 1.0 milestone, since it doesn't require breaking changes.

Make TryInto::Error return the original value instead of a str

Thanks for this PR, a few initial comments: 1. This can only be released as part of 1.0.0, since this is a breaking change. 2. Can you add a test...

Make TryInto::Error return the original value instead of a str

And I'm a bit undecided if I'd like to keep the user friendly error messages too. They are quite helpful in cases of a programming error.

Make TryInto::Error return the original value instead of a str

> One possibility is to support returning the original value through Err as an optional feature. This will not break backward compatibility. I think this is good idea. Could you...

Make TryInto::Error return the original value instead of a str

removing this from the 1.0 milestone as this doesn't need a breaking change

Forward Add, AddAssign, Sub and so on should use generics

To be clear the goald of this request would be to allow for: ```rust assert_eq(Example(1) + 3i32, Example(4)) ``` I think it makes sense to have this feature, but definitely...