Jelte Fennema-Nio comments

Results 697 comments of


                                            Jelte Fennema-Nio

InList is rewritten into = ANY(ARRAY) and leads to bad duckdb plan

I'm trying to limit the amount of changes from the upstream pg_ruleutils. So I'd much rather have this optimization added to duckdb, instead of working around it by generating different...

time_bucket function name clash between timescaleDb and pg_duckdb v1.0.0

Hmm, that should have been fixed by: https://github.com/duckdb/pg_duckdb/pull/747 Are you sure you are installing them in that order? i.e. timescale first and then pg_duckdb

Pgbouncer does not handle unnamed prepared statements when parse and bind are in different transactions

Okay I looked at the logs you shared and what is happening is that diesel sends a Parse (P) message for the unnamed statement in one transaction: ``` dieseltest-pgbouncer-1 |...

Fix application_name_add_host to handle SET application_name

Can you add a test for this? Here's docs on how our testing works: https://github.com/pgbouncer/pgbouncer/blob/master/test/README.md

Fix application_name_add_host to handle SET application_name

I played around with this a bit, and it definitely works better than the current master branch. But the behaviour also a bit more confusing. Because if you set the...

Fix application_name_add_host to handle SET application_name

Apart from my feedback above, this also needs some tests.

Fix application_name_add_host to handle SET application_name

@pinaraf do you still intend to add the tests and docs changes? The code in this PR is good.