citus icon indicating copy to clipboard operation
citus copied to clipboard

Fix system_queries test to actually test the problem

Open Green-Chan opened this issue 1 year ago • 4 comments

The test added in #7604 doesn't reach the HasRangeTableRef function and thus doesn't test what it should.

Green-Chan avatar May 30 '24 12:05 Green-Chan

Could you change the base for this PR to the main? We normally merge everything into main and then cherry-pick to the release branches, but we didn't follow that approach by accident for #7604

JelteF avatar Jun 04 '24 09:06 JelteF

I've rebased the branch to updated main. Check if all GUCs are sorted alphabetically has failed, and I can't see how since shared_library_init.c isn't even changing in this PR. Could someone please help me?

Green-Chan avatar Jul 16 '24 12:07 Green-Chan

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 81.47%. Comparing base (829665e) to head (e11ff75). Report is 1 commits behind head on main.

:x: Your project status has failed because the head coverage (81.47%) is below the target coverage (87.50%). You can increase the head coverage or adjust the target coverage.

:exclamation: There is a different number of reports uploaded between BASE (829665e) and HEAD (e11ff75). Click for more details.

HEAD has 66 uploads less than BASE
Flag BASE (829665e) HEAD (e11ff75)
14_15_upgrade 1 0
16_regress_check-columnar-isolation 1 0
14_16_upgrade 1 0
16_regress_check-follower-cluster 1 0
15_regress_check-follower-cluster 1 0
14_regress_check-follower-cluster 1 0
15_regress_check-columnar-isolation 1 0
14_regress_check-columnar 1 0
15_regress_check-enterprise-isolation-logicalrep-3 1 0
15_regress_check-query-generator 1 0
14_regress_check-split 1 0
14_regress_check-query-generator 1 0
15_regress_check-split 1 0
16_regress_check-enterprise-failure 1 0
15_regress_check-enterprise-failure 1 0
14_regress_check-vanilla 1 0
16_regress_check-failure 1 0
16_regress_check-enterprise 1 0
15_regress_check-enterprise 1 0
14_regress_check-enterprise-isolation 1 0
15_regress_check-enterprise-isolation 1 0
16_regress_check-enterprise-isolation 1 0
15_regress_check-multi-mx 1 0
15_regress_check-enterprise-isolation-logicalrep-1 1 0
14_arbitrary_configs_3 1 0
16_arbitrary_configs_3 1 0
14_regress_check-failure 1 0
15_regress_check-failure 1 0
14_regress_check-multi-mx 1 0
14_regress_check-enterprise-isolation-logicalrep-1 1 0
16_regress_check-enterprise-isolation-logicalrep-1 1 0
16_cdc_installcheck 1 0
15_cdc_installcheck 1 0
15_arbitrary_configs_3 1 0
16_regress_check-operations 1 0
15_regress_check-operations 1 0
14_regress_check-operations 1 0
15_arbitrary_configs_5 1 0
16_arbitrary_configs_5 1 0
15_regress_check-isolation 1 0
16_regress_check-isolation 1 0
16_arbitrary_configs_2 1 0
14_regress_check-isolation 1 0
14_arbitrary_configs_2 1 0
16_regress_check-split 1 0
16_arbitrary_configs_4 1 0
16_arbitrary_configs_0 1 0
15_regress_check-vanilla 1 0
16_regress_check-vanilla 1 0
14_regress_check-enterprise 1 0
15_regress_check-multi 1 0
16_regress_check-multi 1 0
15_arbitrary_configs_4 1 0
16_regress_check-columnar 1 0
16_regress_check-enterprise-isolation-logicalrep-2 1 0
15_regress_check-enterprise-isolation-logicalrep-2 1 0
16_regress_check-enterprise-isolation-logicalrep-3 1 0
14_regress_check-enterprise-isolation-logicalrep-3 1 0
16_regress_check-query-generator 1 0
14_regress_check-enterprise-isolation-logicalrep-2 1 0
15_regress_check-columnar 1 0
14_regress_check-enterprise-failure 1 0
16_regress_check-multi-mx 1 0
16_arbitrary_configs_1 1 0
15_arbitrary_configs_1 1 0
14_arbitrary_configs_1 1 0
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7613      +/-   ##
==========================================
- Coverage   89.61%   81.47%   -8.15%     
==========================================
  Files         283      283              
  Lines       60518    60296     -222     
  Branches     7544     7486      -58     
==========================================
- Hits        54236    49124    -5112     
- Misses       4124     8414    +4290     
- Partials     2158     2758     +600     

codecov[bot] avatar Jul 16 '24 17:07 codecov[bot]

Finally all required tests have passed! @JelteF could you please merge it? I would also love some advice for the future how to deal with randomly failing required tests. I can't rerun them other than by pushing something new to the branch, but pushing disables auto-merge.

Green-Chan avatar Aug 08 '24 05:08 Green-Chan