Jelte Fennema-Nio comments

Results 685 comments of


                                            Jelte Fennema-Nio

Possible feature: deriving std::io::{Read, Write}

The first step would be to implement those for newtypes, which should be fairly simple. But the other part of your idea is quite interesting: deriving traits for an enum...

For generic types, allow to specify concrete types for which to derive for

Thanks for the bugreport, I have not used the deriving `From` with associated types before so it's definitely possible that it's broken. Could you run `cargo expand` and paste it's...

For generic types, allow to specify concrete types for which to derive for

And what does a working implementation look like?

Use Into<_> for datatypes when deriving Constructor

Good suggestion, same goes for From derivation. Not sure when I find the time to do this though.

Fix broken builds against Go 1.6 and 1.7

Could this be reviewed?

New release

This would be really nice. Since the current master is quite far ahead of the last release. `dep` picks the last release if they are available by default. So if...

Are you open to merging this implementation with the derive_more crate?

Just to be clear, I'd be happy to do the work. I mainly would like to know your opinion.

Are you open to merging this implementation with the derive_more crate?

@withoutboats, because of the great work by @Laaas the current version of derive_more has a Display derive that is a superset of the derives from this crate. For the current...

Use edition from Cargo.toml to compile examples

@Geal can this be merged?

Use edition from Cargo.toml to compile examples

@Geal could this be merged please?