Jelte Fennema-Nio
Jelte Fennema-Nio
To be clear, this sounds like a great feature! But it will almost certainly need a few rounds of review and some testing on my part.
I haven't looked much at the code and I'm not really familiar with GSSAPI/Kerberos. In any case this needs some tests in the test suite.
I'll try to take a look in the somewhat near future, but it's a big enough PR that it'll take me some time to review.
Thanks for sharing the updated code, I'll try to look at it soonish. If you rebase with master the Alpine tests should hopefully start passing again. And one of the...
This looks like a useful feature, but I have no experience with LDAP. Could you add a test for this that shows how it's used?
The current tests that we have can be found here: https://github.com/pgbouncer/pgbouncer/blob/master/test/test.sh Sadly there don't seem to be any PAM tests. To make your tests work in CI you'll probably have...
Thanks. To be clear, our CI is not Travis, but Cirrus. And feel free to only do it for (some of) the Linux based runs if that makes it easier...
Needs a rebase before this can be considered. Also valgrind seems to have failed for the old code. The feature itself seems useful, mostly so you don't need to define...
Both me and and @eulerto left reviews on this PR. Without addressing those, this cannot be merged. If you want this feature feel free to make these changes (possibly in...
Do you think there's a way to create a test for the issue you're describing?