go-metrics icon indicating copy to clipboard operation
go-metrics copied to clipboard

Fix broken builds against Go 1.6 and 1.7

Open freeekanayaka opened this issue 8 years ago • 2 comments

Avoid using sort.Slice when building against Go 1.6 or 1.7, instead using the older sort.Sort interface. Fixes #59.

freeekanayaka avatar Aug 19 '17 11:08 freeekanayaka

Hello,

was this PR considered for merging?

I think it's a trivial fix that makes github.com/hashicorp/raft buildable again with Go 1.6, which regressed due to this go-metrics issue (I have an app that requires to be buildable with Go 1.6 and that depends on hashicorp's raft, and hence on go-metrics).

Tahnks

freeekanayaka avatar Sep 04 '17 10:09 freeekanayaka

Could this be reviewed?

JelteF avatar Oct 23 '17 08:10 JelteF