Jelle Zijlstra

Results 643 comments of Jelle Zijlstra

I do agree that `# fmt: off` should stop Black from adding spaces after `#`, and I'd accept a patch fixing that bug. However, according to the OP that's not...

An interesting case from a duplicate: ``` class A: ........ minutes_available_per_week = models.PositiveIntegerField( # fmt: off default=settings.TIME_ESTIMATES["defaults"]["minutes_available_per_week"] # type: ignore # fmt: on ) ```

@jeremyschulman could you report an issue for that? I'd be open to specifically preserving `\b` and `\f`.

We prefer to minimize options that affect formatting. It's also a better user experience for Click users if Black doesn't mangle their docstring in the first place than if they...

Thanks for your PR @KAction! Are you still interested in improving this? Per our stability policy, the feature should initially be enabled only in `--preview` mode.

Reproduces even in `--preview` mode, which should probably split the string.

@pradyunsg I'm not sure why that case particularly needs parentheses. It's not nearly as visually confusing as the examples with `==` cited above.

I now believe we shouldn't make any change here, though I won't object if there's consensus in favor of the change. @Shivansh-007's implementation makes it possible to see the effect...

Why should we provide this feature? What is the use case? And where do you get these environment variable names from? Are they standardized in some way?

This is a reasonable request, but such changes will produce changes to the AST, which goes against Black's general safety guarantee. We already make similar changes in docstrings, but it's...