black
black copied to clipboard
Does flake8 still ignore W503 by default?
Suspect regression. Using v 4.0.1 (Gentoo X86_64). Having just installed black (v22.1.0), reformatting produced multiple W503 messages. Attempted to utilize extended-ignore and reloaded/rescanned project. Warnings persisted. I ensured no W503/W504 ignores were present in code or configuration. Only after adding explicitly W503 to extended-ignore would flake8 be satisfied.
Originally posted by @scottfurry in https://github.com/psf/black/issues/1661#issuecomment-1048462407
I can't reproduce this behaviour but I'm no flake8 pro. If it turns out flake8 requires ignoring W503 line break before binary operator
then let's add it back to the compatible configuration docs (don't forget to explain why it should be ignored like the others!)
I feel like it's better to err on the side of listing more codes in our docs, just in case people explicitly turn on the code or flake8 changes its mind about defaults.
it's still in the default ignores for the latest flake8 (flake8 --help
)
my guess is they might have used --ignore
in one of their configs to try and ignore another error rather than --extend-ignore
and overwritten the default list, hence why they then need to re-add it in.
The black docs already have a warning against enabling W503
and the above flake8 behaviour is in their documentation
Hey all, is this issue still available to take up?
can i claim this issue?
jpy-git's comment is correct. I'm not sure I see anything additional for us to do.