Oleg Agafonov

Results 527 comments of Oleg Agafonov

Verify tests store in `Mage.Verify` folder, not `Mage.Tests`: * `\Mage.Verify\src\test\java\mage\verify\VerifyCardDataTest.java` You can run single test or class by command line, see example in https://github.com/magefree/mage/wiki/Development-Testing-Tools#unit-tests-from-command-line How to view travis logs (search...

@iamrm91 “Allow cast” effects must be applied to all possible characteristics (normal and adventure versions). And it can allow only a specific part (e.g. creature + instant or only creature...

Nope, it’s just a discussion. You can edit it and add line in the start like “That’s wrong, see next” or use `~~wrong~~` to write ~~wrong~~ part.

Yes, it must be improved. Each related cost usage must be carefully reviewed -- if you put filter to current target (CounterType already has predicates) then it will fail due...

There are many code with `AllCreatureTypes` usages, make sure it compatible with new field too: ![shot_240430_211651](https://github.com/magefree/mage/assets/8344157/54da9043-a37c-4cac-a3f3-2c0c67c41434) There are also code like that: ![shot_240430_211947](https://github.com/magefree/mage/assets/8344157/81befaa7-cb72-4c11-98b2-c66cbdd9bde4) I think there are must be many...

Alternative solution for 1 (if possible then it's better): * move all shared code from `HexproofBaseAbility` to `HexproofAbility`; * delete `HexproofBaseAbility`; * make `HexproofAbility` as parent for all other versions.

See some problems with wrong abilities usage, will review later with details.

~~@Susucre please help alex to rebase or create new PR. Current PR contains dirty commits and can’t be reviewed before merge.~~

1. Is it regression from last updates? 2. Is it affect cards with multiple modes only?

@Susucre can be related to zcc too (same tests, but make blinks first);