Jake Wharton comments

Results 1650 comments of


                                            Jake Wharton

checkApi and updateApi ignore methods with reified generics

If memory serves, this is a UAST bug.

checkApi and updateApi ignore methods with reified generics

It sounds like we might need to track both projections of the API. Not here, where we only care about the Kotlin view, but for regular support libraries. For example,...

For consistency, withXXX methods should return the last value of the passed lambda

I'd be open to returning the `Canvas`. I don't see much reason to return from the lambda though.

Add SpannableString.overlay and .overlayAll to apply spans to substrings

This is great. Thank you. My biggest concern here is that the only thing Kotlin-specific is the fact that this is an extension function instead of a static method. I'm...

SeekBar individual listeners

There's already a PR for seekbar as well. Perhaps we should codify a pattern for multi-callback listeners.

Intent filter extension

I don't think I've ever used an IntentFilter in my life. I think we'd need to find out common usage to determine whether this was something likely to be used...

Intent filter extension

Do you have an example we can look at somewhere?

Intent filter extension

I guess my concern here is that this is only for actions and doesn't cover any of the other things you can add to a filter.

Intent filter extension

It probably is, yes, but we could consider adding it to the support libraries. I just have never used `IntentFilter` so I honestly have no idea whether it's worth our...

TextView.setCompoundDrawable... with default arguments

Name won't work. Extensions cannot override members.