Jake Wharton
Jake Wharton
Yeah that makes sense. Given how `runTest` is used, however, have you considered maybe making it a proper wall-clock timeout? It won't cover 100% of tests since some may be...
OkHttp's test suite does not behave this way because it uses JUnit 4 where the instance is shared by the before, test, and after methods. This issue proposes bringing it...
What is the behavior with the executor service in dispatcher in that method?
I see, you're proposing an unstable API for only internal things? I would much prefer a public shutdown API that does everything. I'm not convinced the current position on shutdown...
That would depend on what the type and contents of the binary for the multiplatform artifact was. Seems like a better option would be to change the suffixes to have...
Seems reasonable for QueueDispatcher but not Dispatcher.
Right now this function is equivalent of just calling `Call.execute()` directly so I'm not sure the purpose of wrapping it in a suspending function which never suspends and blocks the...
That is a dangerous assumption. Continuations are just sugar over callbacks. There's nothing specific to them that isn't also true of Rx or futures or promises or this callback. There's...
Canceling the call is a very elegant approach. I like it a lot. Would you put the underlying exception as the cause?
Any chance it can land in a 3.x for Retrofit's sake as well? I'm not _quite_ ready to do the Kotlin dance yet.