JakeQZ
JakeQZ
`Selector::isValid()` is currently used by callers before creating a `Selector`. In all those cases an exception is thrown if it is not valid. It would be cleaner if the `Selector`...
Noted during review of #995: - Why does `Value::parseValue()` stop at `)`? - Rule following rule with `!important` would seemingly be accepted without separating semicolon. - Comments within rules appear...
- One for the `string` parameter; - One for the `int` parameter. The caller should know what type they are passing and therefore be able to call the appropriate method....
It currently works because `Rule::render()` renders individual rules with a trailing semicolon, and `RuleSet::renderRules()` essentially concatenates the results of the former, then appends the `spaceAfterRules` setting (which could be set...
From #911. It should be possible to avoid the duplication of identical test methods for four different classes, somehow.
#807 removes contributor-related content from `README.md`. Most if it is now already covered in `CONTRIBUTING.md`. However, some nuances are not: > * run `composer ci` to run all static and...
This is a task list of enhancements required to fully support the above (strictly). High priority (ideally included in next release) - [x] Allow interchangeability of `rgb` and `rgba`, and...
Continuing from #789. The above-mentioned method is only currently special-casing font properties and the fix for the above. Many properties' values are comma-separated before being space-separated. It might be better...
From #1401. PHPStorm autoformat has a few issues.
The current section in `CONTRIBUTING.md` on rebasing was written based on the experience of rebasing as a *collaborator*. Colloborators can create branches within the repository for PRs, and don't need...