JakeQZ

Boolean or not Boolean (attributes)

6

Arising from #831 is the handling of Boolean vs non-Boolean attributes by the Emogrifier package when parsing and serializing HTML, with respect to the empty attribute syntax. The empty attribute...

Individual style properties overridden by shorthand properties could be eliminated

13

Example in #508. When the resultant inline style is something like `margin-top: 0; margin: 1em;`, the individual property `margin-top: 0` is completely overridden by the shorthand `margin: 1em` and could...

Inconsistent behaviour of Value::parseValue with odd vs even number of consecutive delimiters

2

Initial investigation arises from the infinite loop fix in #390, which it turns out was fixed separately by #413. I tried throwing the following at `Value::parseValue`: - `/!;` - `//!;`...

E.g. `(1rem + 1vw) * 2` - in context e.g.: `font-size: clamp(2.5rem, (1rem + 1vw) * 2, 4rem);`. We need to know if these are parsed correctly, or there is...

Review braces_position coding style enforcement in PHP CS Fixer

2

A single-line function/method declaration has the code-block opening brace on the next line: ```php function a() { ``` Multiline declarations have this on the same line as the closing parenthesis...

[TASK] Use delegation for `DeclarationBlock` -> `RuleSet`

1

... rather than inheritance. This will allow `DeclarationBlock` to instead extend `CSSBlockList` in order to support [CSS nesting](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_nesting). This is a slightly-breaking change, since now `CSSBlockList::getAllRuleSets()` will include the `RuleSet`...

Add `trait` for 'standard' `Commentable` implementation

1

The various classes that implement `Commentable` all seem to have exactly the same implementation. This duplication could be avoided by using a `trait` for a 'standard' implementation.

Use `null` for `Import::$mediaQuery` to indicate absence

1

The code currently uses both `null` and an empty string to indicate there is no media query. It also appears that when it is an empty string, an extra space...

During removal of support for IE hacks (#995), it was found that - `parseIdentifier()` treats the first character differently to subsequent characters - it does not attempt to escape the...

It's an ordering mechanism. [MDN](https://developer.mozilla.org/en-US/docs/Web/CSS/CSS_cascade/Specificity) suggests putting the values into a three-colum vector. `Selector::getSpecificity()` may fail to give the correct ordering if there are 10 or more of the same...